Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/19863/21/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19863/21/be/src/common/init.cc@308 PS21, Line 308: static std::string FindFileInPath( : const filesystem::path& path, const std::regex& pattern) { : if (path.empty()) return ""; : if (!filesystem::exists(path)) return ""; : if (filesystem::is_directory(path)) { : for (filesystem::directory_entry& child : filesystem::directory_iterator(path)) { : // if child matches jamm-*.jar, use it : if (std::regex_match(child.path().filename().string(), pattern)) { : return child.path().string(); : } : } : } else if (std::regex_match(path.filename().string(), pattern)) { : return path.string(); : } : return ""; : } Should we put this in a utility file like be/src/util/filesystem-util.*? That would make it possible to write a backend test for it. I guess the other question is whether the CLASSPATH walk itself is an interesting utility function as well. http://gerrit.cloudera.org:8080/#/c/19863/21/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/19863/21/bin/run-all-tests.sh@247 PS21, Line 247: # Add Jamm as javaagent for CatalogdMetaProviderTest.testWeights : JAMM_JAR=$(compgen -G ${IMPALA_HOME}/fe/target/dependency/jamm-*.jar) : export JAVA_TOOL_OPTIONS="${JAVA_TOOL_OPTIONS-} -javaagent:${JAMM_JAR}" Do the add-opens that we have in init.cc need to be specified here too? -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 21 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 17:15:07 +0000 Gerrit-HasComments: Yes
