Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: If a non-partitioned table update catalog fails, invalidate the table. ...................................................................... Patch Set 15: (2 comments) Thanks for contributing this fix! http://gerrit.cloudera.org:8080/#/c/19878/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19878/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@779 PS15, Line 779: DebugUtils.throwExceptionByDebugAction(debugActions, Can we use DebugUtils.hasDebugAction() directly? When it's set, throws a CatalogException. http://gerrit.cloudera.org:8080/#/c/19878/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1384 PS15, Line 1384: resetPartitions(); Can we simply move this to line 1400 (right after the call of loadFileMetadataForPartitions)? Then when loadFileMetadataForPartitions throws exceptions, resetPartitions() hasn't been called so we won't have an empty map. -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 15 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 21 Jun 2023 09:59:40 +0000 Gerrit-HasComments: Yes
