Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: For non-partitioned tables, defer the resetPartitions() until the file metadata is loaded. ...................................................................... Patch Set 18: Code-Review+1 (3 comments) LGTM. Just have some minor comments. http://gerrit.cloudera.org:8080/#/c/19878/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19878/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1380 PS18, Line 1380: } nit: add a comment like "Step 1: fetch external metadata" http://gerrit.cloudera.org:8080/#/c/19878/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1384 PS18, Line 1384: setPrototypePartition(msTbl.getSd()); nit: let's move this to line 1397 as well so all the modifications take place after fetching external metadata. http://gerrit.cloudera.org:8080/#/c/19878/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1397 PS18, Line 1397: setUnpartitionedTableStats(partBuilder); nit: add a comment above this for "Step 2: update internal fields" -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 18 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 26 Jun 2023 11:01:02 +0000 Gerrit-HasComments: Yes
