Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/19863/26/be/src/util/filesystem-util.h File be/src/util/filesystem-util.h: http://gerrit.cloudera.org:8080/#/c/19863/26/be/src/util/filesystem-util.h@96 PS26, Line 96: static std::string FindFileInPath(const string& path, const std::string& regex); Nit: What happens if there are multiple matches? http://gerrit.cloudera.org:8080/#/c/19863/26/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/19863/26/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@2020 PS26, Line 2020: private static SizeOf SIZEOF = SizeOf.newInstance(BYPASS_FLYWEIGHT, CACHE_SIZES); : private static MemoryMeter METER = MemoryMeter.builder().build(); Nit: It would be nice to have a clean separation where only one of jamm/ehcache is instantiated at a time (both here and with the -javaagent arguments). -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 26 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 21 Jun 2023 21:53:31 +0000 Gerrit-HasComments: Yes
