Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG@14 PS1, Line 14: eventTime Do we really compare the eventTime? http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG@19 PS1, Line 19: By comparing the lastRefreshEventId to current event id in the event How do we deal with batch events? For partition level INSERT/ALTER events, we now process them in batch if they are consecutive and belong to the same table. It seems we need to skip some events when adding them in a batch. http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1915 PS1, Line 1915: long latestEventId = getLatestEventId(client); please log this so we can reason about why an older event is skipped. http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2883 PS1, Line 2883: long latestEventId = getLatestEventId(client); Please log this so we can reason about why an older event is skipped. http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/Table.java@1048 PS1, Line 1048: debug Let's bump this to INFO level to ease debug. http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1540 PS1, Line 1540: nit: remove blank line http://gerrit.cloudera.org:8080/#/c/20022/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20022/1/tests/custom_cluster/test_events_custom_configs.py@321 PS1, Line 321: """alter table {db}.{tbl} set tblproperties ('foo'='bar');""" ALTER event generated by this might already be ignored by the change of IMPALA-11534. Can we use INSERT? -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 07:53:00 +0000 Gerrit-HasComments: Yes
