Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG@14 PS1, Line 14: eventTime > Do we really compare the eventTime? No, we actually compare with eventId. But for simplicity in talking terms I mentioned it as event time. Implementation wise we actually compare eventId. http://gerrit.cloudera.org:8080/#/c/20022/1//COMMIT_MSG@19 PS1, Line 19: By comparing the lastRefreshEventId to current event id in the event > How do we deal with batch events? For partition level INSERT/ALTER events, Good point!! Addressed in the current patch set. http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1915 PS1, Line 1915: msPartition.getSd(), msPartition, permCache, partBuilder); > please log this so we can reason about why an older event is skipped. Done http://gerrit.cloudera.org:8080/#/c/20022/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2883 PS1, Line 2883: * @param fileMetadataLoadOpts describes how to load file metadata > Please log this so we can reason about why an older event is skipped. Done -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 23:37:40 +0000 Gerrit-HasComments: Yes
