Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 )
Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Thanks, looks good, just a nit. http://gerrit.cloudera.org:8080/#/c/19881/7/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java File fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java: http://gerrit.cloudera.org:8080/#/c/19881/7/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java@25 PS7, Line 25: truncation > As the main goal of this change is to add Hive-like implicit cast capabilit Ok, we should follow Hive here. http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java File fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java: http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java@24 PS8, Line 24: STRING Nit: I think this should be 'string' because it doesn't refer to the concrete STRING type but generally to string-like types. -- To view, visit http://gerrit.cloudera.org:8080/19881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5db2301216c2e088b4b3e4f6cb5a1fd10600f7 Gerrit-Change-Number: 19881 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 27 Jun 2023 08:51:16 +0000 Gerrit-HasComments: Yes
