Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 )
Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table ...................................................................... Patch Set 8: (3 comments) Hi Peter, nice change and design! LGTM, just left some nits on commenting. http://gerrit.cloudera.org:8080/#/c/19881/8/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/19881/8/common/thrift/ImpalaService.thrift@796 PS8, Line 796: IMPALA-10173 nit: I think there is no need to mention the Jira here in this case, it is available in the history http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/CompatibilityRule.java File fe/src/main/java/org/apache/impala/catalog/CompatibilityRule.java: http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/CompatibilityRule.java@24 PS8, Line 24: */ nit: could you add an example? http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java File fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java: http://gerrit.cloudera.org:8080/#/c/19881/8/fe/src/main/java/org/apache/impala/catalog/TypeCompatibility.java@22 PS8, Line 22: TypeCompatibility I really like this design. nit: Could you add some basic information on the class in comments. ie.: it is used to decide the whether casts between types are compatible. -- To view, visit http://gerrit.cloudera.org:8080/19881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5db2301216c2e088b4b3e4f6cb5a1fd10600f7 Gerrit-Change-Number: 19881 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 10:58:51 +0000 Gerrit-HasComments: Yes
