Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20078 )
Change subject: IMPALA-11877: (part 2) Add support for DELETE statements for PARTITIONED Iceberg tables ...................................................................... Patch Set 3: PS3 reverts some parts of the InsertStmt/ModifyStmt refactorings as these introduced a bug in Kudu UPDATEs. Problem is ModifyStmt handles the expressions and source statements differently than INSERT, i.e. ModifyStmt sets the source statement and exprs in the first run of the analysis, then reuses them in the second run. I have a feeling that this behavior might have subtle bugs that I'll investigate further, but this is out of scope of this CR. -- To view, visit http://gerrit.cloudera.org:8080/20078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28b06f240c23c336a7c5b6ef22fe2ee0a21f7b60 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 27 Jun 2023 13:16:33 +0000 Gerrit-HasComments: No
