Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20078 )
Change subject: IMPALA-11877: (part 2) Add support for DELETE statements for PARTITIONED Iceberg tables ...................................................................... Patch Set 4: (1 comment) Thanks Zoltan, looks good, just one more question. http://gerrit.cloudera.org:8080/#/c/20078/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete-partitioned.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-delete-partitioned.test: http://gerrit.cloudera.org:8080/#/c/20078/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-delete-partitioned.test@1 PS4, Line 1: ==== Would it make sense to add a few basic tests of the new virtual columns as well? Although, those are tested indirectly by these tests. -- To view, visit http://gerrit.cloudera.org:8080/20078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28b06f240c23c336a7c5b6ef22fe2ee0a21f7b60 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 13:20:02 +0000 Gerrit-HasComments: Yes
