Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895 ...................................................................... Patch Set 1: (1 comment) Thank you for working on this, Fang-Yu. I just have one request. http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template File testdata/cluster/ranger/ranger-admin-default-site.xml.template: http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template@305 PS1, Line 305: ranger.jpa.jdbc.initialpoolsize In the JIRA, you mention "In this regard, we could probably add these 3 new properties first and then remove the unnecessary properties once we have bumped up the build number that includes RANGER-2895.". Can you rephrase that statement into commit message of this patch? Maybe also spell out the config key that is being deprecated. Are you planning to file a follow up JIRA to remove the deprecated config keys? -- To view, visit http://gerrit.cloudera.org:8080/20129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae Gerrit-Change-Number: 20129 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 00:13:57 +0000 Gerrit-HasComments: Yes
