Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20129 )

Change subject: IMPALA-12248: Add three configuration properties after 
RANGER-2895
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1:
>
> (1 comment)
>
> Thank you for working on this, Fang-Yu.
> I just have one request.

Thanks for the review Riza! I have addressed your comments in the previous 
patch. Let me know if you have any other suggestion.

http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template
File testdata/cluster/ranger/ranger-admin-default-site.xml.template:

http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template@305
PS1, Line 305: ranger.jpa.jdbc.initialpoolsize
> In the JIRA, you mention "In this regard, we could probably add these 3 new
Thanks Riza!

I have revised the commit message in the next patch and also created 
IMPALA-12250 to keep track of the task of removing the deprecated property.



--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 28 Jun 2023 05:52:42 +0000
Gerrit-HasComments: Yes

Reply via email to