Surya Hebbar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20008 )
Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics ...................................................................... IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics This patch adds support for a stacked area chart for CPU utilization to the query timeline display, while also providing the ability to scale timetick values, precision, and the ability to horizontally scale the fragment timing diagram along with the utilization chart. Rendering of different components within the diagram has been decoupled to isolate scaling of timeticks, also to greatly improve the overall efficiency by making the rendering functions asynchronous for better performance during resize events. Support for experimental profile V2 is currently not included. Scaling a large number of values to support profile V2 would be possible with appropriate down-sampling in the back-end. The charting library has been tested on a large number of values to ensure this would be possible in the future. The following are the associated key bindings to scale the timeline with mouse wheel events. - shift + wheel events on #fragment_diagram - shift + wheel events on #timeticks_footer - alt + shift + wheel events on #timeticks_footer for precision control Note: Ctrl + mouse wheel events and ctrl + '+'/'-' events can be used to resize the timeline through the browser. Mouse wheel events have been associated with respective components for better efficiency and maintainability. Constraints have been added to above attributes to limit scaling/zooming for appropriate display and rendering across all DOM elements. RuntimeProfile contains samples of CPU utilization metrics for user, sys and iowait. These time series counters are available within the profile having the following names. Per Node Profiles - - HostCpuIoWaitPercentage - HostCpuSysPercentage - HostCpuUserPercentage The samples are updated based on 'periodic_counter_update_period_ms' providing the 'period' within profile's 'Per Node Profiles'. These are retrieved from the ChunkedTimeSeriesCounter in the RuntimeProfile. Currently, JSON profiles and webUI summary pages contain the downsampled values. Aggregate CPU usage for each node is being calculated after accumulating the basis point values for user, sys and iowait. These are being displayed after grouping the associated counters for each node as a stacked line chart. c3.js charting library based on d3.v5 is being used to plot the utilization. The license associated with d3 v5 during the related time frame has been included along with the charting library's. Testing: Manual testing with TPC-DS and TPC-H queries Change-Id: Idea2a6db217dbfaa7a0695aeabb6d9c1ecf62158 --- M .gitattributes M LICENSE.txt M bin/rat_exclude_files.txt A www/c3/c3.v7.min.css A www/c3/c3.v7.min.js A www/d3.v5.min.js M www/query_timeline.tmpl 7 files changed, 353 insertions(+), 90 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/20008/3 -- To view, visit http://gerrit.cloudera.org:8080/20008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idea2a6db217dbfaa7a0695aeabb6d9c1ecf62158 Gerrit-Change-Number: 20008 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
