Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20008 )
Change subject: IMPALA-12182: Add CPU utilization chart for RuntimeProfile's sampled metrics ...................................................................... Patch Set 4: (4 comments) End time for CPU utilization chart is not shown for some queries. When the end time is shown, it's partially cut off in the downloaded file. http://gerrit.cloudera.org:8080/#/c/20008/4/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20008/4/www/query_timeline.tmpl@693 PS4, Line 693: if (cpu_utilization_chart == undefined){ nit: add space before { http://gerrit.cloudera.org:8080/#/c/20008/4/www/query_timeline.tmpl@713 PS4, Line 713: Decrease : <i><b>periodic_counter_update_period_ms</b></i> to increase the granularity of : utilization plot nit: give more detail for the warning message, like "Warning: not enough samples for CPU utilization plot. Please decrease the value of starting flag variable 'periodic_counter_update_period_ms" to increase the granularity of CPU utilization plot." http://gerrit.cloudera.org:8080/#/c/20008/4/www/query_timeline.tmpl@728 PS4, Line 728: for (var k = 0; k <= max_samples_available; k++){ nit: add space before { http://gerrit.cloudera.org:8080/#/c/20008/4/www/query_timeline.tmpl@852 PS4, Line 852: window.onload = function(){ nit: add space before { -- To view, visit http://gerrit.cloudera.org:8080/20008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea2a6db217dbfaa7a0695aeabb6d9c1ecf62158 Gerrit-Change-Number: 20008 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:48:51 +0000 Gerrit-HasComments: Yes
