Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 8: > (1 comment) > > Found another issue when building RPM on Redhat 8: > > + PYTHON3=/usr/libexec/platform-python > + /usr/lib/rpm/redhat/brp-mangle-shebangs > *** ERROR: ambiguous python shebang in > /opt/impala/shell/lib/option_parser.py: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/lib/impala_client.py: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/lib/TSSLSocketWithWildcardSAN.py: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/StatestoreService/StatestoreService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/StatestoreService/StatestoreSubscriber-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/beeswaxd/BeeswaxService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/ImpalaService/ImpalaService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/ImpalaService/ImpalaHiveServer2Service-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/TCLIService/TCLIService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/fb303/FacebookService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/hive_metastore/ThriftHiveMetastore-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/CatalogService/CatalogService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in > /opt/impala/shell/gen-py/NetworkTest/NetworkTestService-remote: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. > *** ERROR: ambiguous python shebang in /opt/impala/shell/impala_shell.py: > #!/usr/bin/env python. Change it to python3 (or python2) > explicitly. Hmm, some of these files don't need shebangs (option_parser.py, impala_client.py, TSSLSocketWithWildcardSAN.py), because they don't have main functions. I have been meaning to crack down on this (and files marked as executable). I'll file a JIRA. Maybe we can exclude the *-remote files? I don't think we use those. That leaves impala_shell.py. I also think we might be able to rework this so it doesn't need a shebang. We have a shell script that invokes it (impala-shell). We can change the locations that call this to not execute impala_shell.py directly. I can file a JIRA to track that down. -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 20:40:48 +0000 Gerrit-HasComments: No
