Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails ...................................................................... Patch Set 28: (1 comment) http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py@505 PS27, Line 505: v.get_value('table_format').file_format == 'text') > Ack hmm, I don't see the constraint of compression_codec == 'none' is added. Without it, this test will run on all text formats in exhaustive jobs, e.g. text/none, text/def/block, text/gzip/block, text/bzip/block, text/snap/block You can verify it using the following command: impala-py.test --exploration_strategy=exhaustive tests/query_test/test_insert.py::TestInsertNonPartitionedTable The test just creates the table in text/none format, i.e. without compression. Let's add the constraint of compression_codec == 'none' so it won't waste time in testing other compressed text formats. -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 28 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 02:31:27 +0000 Gerrit-HasComments: Yes
