Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19878 )
Change subject: IMPALA-12131: Fix empty partition map in non-partitioned table when file metadata loading fails ...................................................................... Patch Set 27: (2 comments) http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py@505 PS27, Line 505: is_supported_insert_format(v.get_value('table_format'))) The test actaully just creates tables in TEXT format. No need to test on parquet here. Let's limit it to run only for text/none: cls.ImpalaTestMatrix.add_constraint(lambda v:\ (v.get_value('table_format').file_format == 'text' and \ v.get_value('table_format').compression_codec == 'none')) http://gerrit.cloudera.org:8080/#/c/19878/27/tests/query_test/test_insert.py@513 PS27, Line 513: Tests an empty partition map appears in non-partitioned table : after file metadata loading fails. This comment will be confusing. It sounds like we expect an empty partition map but we won't have it after this fix. Please change it to something like "Tests metadata won't be corrupted after file metadata loading fails in non-partitioned tables." -- To view, visit http://gerrit.cloudera.org:8080/19878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28e76a73b7905c24eb93b935124d20ea7abe8513 Gerrit-Change-Number: 19878 Gerrit-PatchSet: 27 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Manish Maheshwari <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 28 Jun 2023 23:55:27 +0000 Gerrit-HasComments: Yes
