Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20137 )

Change subject: IMPALA-12252: Support distcc server on Ubuntu 20.04
......................................................................


Patch Set 1:

(1 comment)

How much do we actually worry about Ubuntu 16?
- it has been out of standard maintenance for two years now
- current Impala precommit processes still depend on it, but that does not use 
distcc, and it will be replaced by a process based on Ubuntu 20.04 shortly
- individual developers should have migrated off of it long ago
- even if this patch broke distcc on Ubuntu 16, it only breaks distcc, not 
compilation in general

http://gerrit.cloudera.org:8080/#/c/20137/1/bin/distcc/distcc_server_bootstrap.sh
File bin/distcc/distcc_server_bootstrap.sh:

http://gerrit.cloudera.org:8080/#/c/20137/1/bin/distcc/distcc_server_bootstrap.sh@78
PS1, Line 78: sudo ln -s $(which ccache) /usr/lib/distcc/ccache
> I haven't checked, but does this directory exist for Ubuntu 16/18?
on my Ubuntu 18.04 system dpkg tells me that it is created by the distcc 
package:

-----console capture--------
laszlog@laszlog2:~/impala-in-docker/impala$ dpkg -L distcc
/.
/etc
/etc/distcc
/etc/distcc/hosts
/etc/init.d
/etc/init.d/distcc
/etc/logrotate.d
/etc/logrotate.d/distcc
/usr
/usr/bin
/usr/bin/distcc
/usr/bin/distccd
/usr/bin/distccmon-text
/usr/bin/lsdistcc
/usr/lib
/usr/lib/distcc
....more output clipped.....
-----end of console capture--------



--
To view, visit http://gerrit.cloudera.org:8080/20137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb4dbb210ec22195450dd1a0cb64e00a4559c19
Gerrit-Change-Number: 20137
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Comment-Date: Thu, 29 Jun 2023 17:15:53 +0000
Gerrit-HasComments: Yes

Reply via email to