Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20137 )

Change subject: IMPALA-12252: Support distcc server on Ubuntu 20.04
......................................................................


Patch Set 1:

> > (1 comment)
 > >
 > > How much do we actually worry about Ubuntu 16?
 > > - it has been out of standard maintenance for two years now
 > > - current Impala precommit processes still depend on it, but that
 > > does not use distcc, and it will be replaced by a process based
 > on
 > > Ubuntu 20.04 shortly
 > > - individual developers should have migrated off of it long ago
 > > - even if this patch broke distcc on Ubuntu 16, it only breaks
 > > distcc, not compilation in general
 >
 > I don't care about Ubuntu 16.04. If we want to drop it, we can. So,
 > basically:
 > Option 1: Drop Ubuntu 16.04
 > Option 2: Spin up an Ubuntu 16.04 docker container and see if
 > /usr/lib/distcc exists after installing distcc. If yes, then we're
 > done. If no, add an if statement (or go with Option 1).
 >
 > Is that reasonable?

Ordinarily, I would check this myself, but I'm away from my dev workstation.


--
To view, visit http://gerrit.cloudera.org:8080/20137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb4dbb210ec22195450dd1a0cb64e00a4559c19
Gerrit-Change-Number: 20137
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Comment-Date: Thu, 29 Jun 2023 17:35:22 +0000
Gerrit-HasComments: No

Reply via email to