Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20170 )
Change subject: IMPALA-11980: Move impala shell code to impala_shell subdirectory and use absolute_import ...................................................................... Patch Set 3: (50 comments) http://gerrit.cloudera.org:8080/#/c/20170/3/bin/impala-shell.sh File bin/impala-shell.sh: http://gerrit.cloudera.org:8080/#/c/20170/3/bin/impala-shell.sh@64 PS3, Line 64: exec "${IMPALA_PYTHON_EXECUTABLE}" ${EXTRA_ARGS:-} ${SHELL_HOME}/impala_shell/impala_shell.py "$@" line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/ImpalaHttpClient.py@48 PS3, Line 48: class ImpalaHttpClient(TTransportBase): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/TSSLSocketWithWildcardSAN.py File shell/impala_shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/TSSLSocketWithWildcardSAN.py@27 PS3, Line 27: class CertificateError(ValueError): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/TSSLSocketWithWildcardSAN.py@31 PS3, Line 31: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/cookie_util.py File shell/impala_shell/cookie_util.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/cookie_util.py@22 PS3, Line 22: import six flake8: F401 'six' imported but unused http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@40 PS3, Line 40: q flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@44 PS3, Line 44: e flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@102 PS3, Line 102: HS2_LOG_PROGRESS_REGEX = re.compile("Query.*Complete \([0-9]* out of [0-9]*\)\n") flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@102 PS3, Line 102: \ flake8: W605 invalid escape sequence '\(' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@102 PS3, Line 102: \ flake8: W605 invalid escape sequence '\)' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@110 PS3, Line 110: class QueryOptionLevels: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@196 PS3, Line 196: e flake8: E722 do not use bare 'except' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@607 PS3, Line 607: flake8: E201 whitespace after '[' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@615 PS3, Line 615: flake8: E202 whitespace before ']' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@715 PS3, Line 715: = flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@741 PS3, Line 741: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@783 PS3, Line 783: o flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_client.py@1451 PS3, Line 1451: r flake8: E111 indentation is not a multiple of 2 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@77 PS3, Line 77: def strip_comments(sql): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@169 PS3, Line 169: flake8: E201 whitespace after '[' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@169 PS3, Line 169: flake8: E202 whitespace before ']' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@183 PS3, Line 183: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@184 PS3, Line 184: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@185 PS3, Line 185: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@186 PS3, Line 186: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@220 PS3, Line 220: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@261 PS3, Line 261: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@410 PS3, Line 410: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@757 PS3, Line 757: = flake8: E711 comparison to None should be 'if cond is None:' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@841 PS3, Line 841: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1106 PS3, Line 1106: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1106 PS3, Line 1106: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1183 PS3, Line 1183: t flake8: F841 local variable 'tbl_name' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1312 PS3, Line 1312: / flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1363 PS3, Line 1363: w flake8: F841 local variable 'wait_to_finish' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1480 PS3, Line 1480: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1781 PS3, Line 1781: c flake8: F812 list comprehension redefines 'cmd_names' from line 1779 http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1832 PS3, Line 1832: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1875 PS3, Line 1875: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1902 PS3, Line 1902: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@1957 PS3, Line 1957: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@2022 PS3, Line 2022: def impala_shell_main(): flake8: E303 too many blank lines (3) http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@2124 PS3, Line 2124: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@2130 PS3, Line 2130: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@2216 PS3, Line 2216: i flake8: F401 'thrift.protocol.fastbinary' imported but unused http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/impala_shell.py@2232 PS3, Line 2232: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/option_parser.py@268 PS3, Line 268: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/option_parser.py@269 PS3, Line 269: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/option_parser.py@270 PS3, Line 270: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/20170/3/shell/impala_shell/shell_output.py@137 PS3, Line 137: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/20170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80861db989834e519aa6afb4890eab75146dc093 Gerrit-Change-Number: 20170 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 17:35:51 +0000 Gerrit-HasComments: Yes
