Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20170 )
Change subject: IMPALA-11980: Move impala shell code to impala_shell subdirectory and use absolute_import ...................................................................... Patch Set 4: (47 comments) http://gerrit.cloudera.org:8080/#/c/20170/4/bin/impala-shell.sh File bin/impala-shell.sh: http://gerrit.cloudera.org:8080/#/c/20170/4/bin/impala-shell.sh@64 PS4, Line 64: exec "${IMPALA_PYTHON_EXECUTABLE}" ${EXTRA_ARGS:-} ${SHELL_HOME}/impala_shell/impala_shell.py "$@" line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/ImpalaHttpClient.py@48 PS4, Line 48: class ImpalaHttpClient(TTransportBase): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/TSSLSocketWithWildcardSAN.py File shell/impala_shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/TSSLSocketWithWildcardSAN.py@27 PS4, Line 27: class CertificateError(ValueError): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/TSSLSocketWithWildcardSAN.py@31 PS4, Line 31: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@104 PS4, Line 104: HS2_LOG_PROGRESS_REGEX = re.compile("Query.*Complete \([0-9]* out of [0-9]*\)\n") flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@104 PS4, Line 104: \ flake8: W605 invalid escape sequence '\(' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@104 PS4, Line 104: \ flake8: W605 invalid escape sequence '\)' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@112 PS4, Line 112: class QueryOptionLevels: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@198 PS4, Line 198: e flake8: E722 do not use bare 'except' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@609 PS4, Line 609: flake8: E201 whitespace after '[' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@617 PS4, Line 617: flake8: E202 whitespace before ']' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@717 PS4, Line 717: = flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@743 PS4, Line 743: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@785 PS4, Line 785: o flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_client.py@1453 PS4, Line 1453: r flake8: E111 indentation is not a multiple of 2 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@77 PS4, Line 77: def strip_comments(sql): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@169 PS4, Line 169: flake8: E201 whitespace after '[' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@169 PS4, Line 169: flake8: E202 whitespace before ']' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@183 PS4, Line 183: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@184 PS4, Line 184: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@185 PS4, Line 185: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@186 PS4, Line 186: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@220 PS4, Line 220: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@261 PS4, Line 261: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@410 PS4, Line 410: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@757 PS4, Line 757: = flake8: E711 comparison to None should be 'if cond is None:' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@841 PS4, Line 841: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1106 PS4, Line 1106: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1106 PS4, Line 1106: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1183 PS4, Line 1183: t flake8: F841 local variable 'tbl_name' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1312 PS4, Line 1312: / flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1363 PS4, Line 1363: w flake8: F841 local variable 'wait_to_finish' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1480 PS4, Line 1480: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1781 PS4, Line 1781: c flake8: F812 list comprehension redefines 'cmd_names' from line 1779 http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1832 PS4, Line 1832: l flake8: E741 ambiguous variable name 'l' http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1875 PS4, Line 1875: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1902 PS4, Line 1902: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@1957 PS4, Line 1957: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@2022 PS4, Line 2022: def impala_shell_main(): flake8: E303 too many blank lines (3) http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@2124 PS4, Line 2124: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@2130 PS4, Line 2130: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@2216 PS4, Line 2216: i flake8: F401 'thrift.protocol.fastbinary' imported but unused http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/impala_shell.py@2232 PS4, Line 2232: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/option_parser.py@268 PS4, Line 268: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/option_parser.py@269 PS4, Line 269: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/option_parser.py@270 PS4, Line 270: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/20170/4/shell/impala_shell/shell_output.py@137 PS4, Line 137: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/20170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80861db989834e519aa6afb4890eab75146dc093 Gerrit-Change-Number: 20170 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 09 Sep 2023 06:05:03 +0000 Gerrit-HasComments: Yes
