Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20187 )
Change subject: IMPALA-12239: BitWidthZeroRepeated seems to be flaky ...................................................................... Patch Set 1: Code-Review+2 (1 comment) This makes sense to me, thanks for fixing this http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h File be/src/util/bit-stream-utils.inline.h: http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h@249 PS1, Line 249: if (LIKELY(buffer_pos_ != buffer_end_)) { For my own understanding: If num_bytes is 0, then is it always true that buffer_pos_ == buffer_end_? -- To view, visit http://gerrit.cloudera.org:8080/20187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84645271101b4bd594dd25929924a3549c223244 Gerrit-Change-Number: 20187 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 20:05:06 +0000 Gerrit-HasComments: Yes
