Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20187 )
Change subject: IMPALA-12239: BitWidthZeroRepeated seems to be flaky ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h File be/src/util/bit-stream-utils.inline.h: http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h@249 PS1, Line 249: if (LIKELY(buffer_pos_ != buffer_end_)) { > For my own understanding: I don't think that has to be true. I don't know if there is a sensible use case where it isn't, but when using BatchedBitReader within an RleBatchDecoder (like in the RleTest.BitWidthZeroRepeated test case), it is not illegal to have two consecutive but separate repeated runs of zeros, where the values themselves are stored on 0 bytes (bit width is 0) but the run lengths each take a byte. When reading the values from the first run, 'num_bytes' will be 0 but we're not at the end of the buffer because the run length of the second run is yet to be read. -- To view, visit http://gerrit.cloudera.org:8080/20187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84645271101b4bd594dd25929924a3549c223244 Gerrit-Change-Number: 20187 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 16:28:49 +0000 Gerrit-HasComments: Yes
