Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20189 )
Change subject: IMPALA-12281: Disallow unsetting REQUEST_POOL if it is set by client ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20189/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20189/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2125 PS1, Line 2125: // If it is for a single node plan, enable_replan is disabled, or it is not a query > Maybe add a test setting it to empty string then? I changed my mind. I switch to use isSetRequest_pool in patch set 2, but also add Preconditions.checkState after it. Also add test case with emtpy REQUEST_POOL. But I think somewhere in impala shell client or thrift library, there is already a sanity check for empty string and I don't see empty REQUEST_POOL printed in query profile. This new testcase confirm it. -- To view, visit http://gerrit.cloudera.org:8080/20189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5036859d51bc64f568da405f730c8f3ffebb742 Gerrit-Change-Number: 20189 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Jul 2023 18:16:34 +0000 Gerrit-HasComments: Yes
