Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20189 )
Change subject: IMPALA-12281: Disallow unsetting REQUEST_POOL if it is set by client ...................................................................... IMPALA-12281: Disallow unsetting REQUEST_POOL if it is set by client IMPALA-12056 enable child query to unset REQUEST_POOL if it is set by Frontend.java as part of executor group selection. However, the implementation miss to setRequest_pool_set_by_frontend(false) if REQUEST_POOL is explicitly set by client request through impala-shell configuration. This cause child query to always unset REQUEST_POOL if parent query was executed via impala-shell. This patch fix the issue by checking query options that comes from client. This patch also tidy up null and empty REQUEST_POOL checking by using StringUtils.isNotEmpty(). Testing: - Add testcase in test_query_cpu_count_divisor_default Change-Id: Ib5036859d51bc64f568da405f730c8f3ffebb742 Reviewed-on: http://gerrit.cloudera.org:8080/20189 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Riza Suminto <[email protected]> --- M fe/src/main/java/org/apache/impala/service/Frontend.java M tests/custom_cluster/test_executor_groups.py 2 files changed, 50 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Riza Suminto: Verified -- To view, visit http://gerrit.cloudera.org:8080/20189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5036859d51bc64f568da405f730c8f3ffebb742 Gerrit-Change-Number: 20189 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
