Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20197 )
Change subject: IMPALA-12285: Use targetType in string-to-numeric literal conversion ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20197/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20197/1//COMMIT_MSG@9 PS1, Line 9: This change fixes mismatched type problems when an implicitly casted Please add the problem example also here. http://gerrit.cloudera.org:8080/#/c/20197/1/testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test File testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test: http://gerrit.cloudera.org:8080/#/c/20197/1/testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test@155 PS1, Line 155: float_col Is there a reason this is 'float_col' and not an integer column? -- To view, visit http://gerrit.cloudera.org:8080/20197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2141e7ab164af55a7fa66dda05fe6dcbd7379b69 Gerrit-Change-Number: 20197 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 14 Jul 2023 12:09:18 +0000 Gerrit-HasComments: Yes
