Peter Rozsa has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/20197 )
Change subject: IMPALA-12285: Use targetType in string-to-numeric literal
conversion
......................................................................
IMPALA-12285: Use targetType in string-to-numeric literal conversion
This change fixes mismatched type problems when an implicitly casted
string literal gets converted to a numeric type. Example:
'INSERT INTO example(float_col) VALUES ("0"), (15629);'
After this change, StringLiteral's 'convertToNumber' method will
consider the targetType parameter when creates a new NumericLiteral.
Test:
- test case added to insert-unsafe.test
Change-Id: I2141e7ab164af55a7fa66dda05fe6dcbd7379b69
---
M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java
M testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/20197/3
--
To view, visit http://gerrit.cloudera.org:8080/20197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2141e7ab164af55a7fa66dda05fe6dcbd7379b69
Gerrit-Change-Number: 20197
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
