Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20192 )
Change subject: IMPALA-12267: DMLs/DDLs can hang as a result of catalogd restart ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc@382 PS1, Line 382: -1 > I think 5 minutes should be enough but maybe don't need that long. There ar But as far as I know condition variables may receive spurious wakeups, so in theory we may wake up without any real reason. I don't know how likely it is but it is not guaranteed. http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc@2238 PS1, Line 2238: > nit: 4 indent spaces Done http://gerrit.cloudera.org:8080/#/c/20192/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/20192/1/tests/custom_cluster/test_restart_services.py@194 PS1, Line 194: @ > flake8: E301 expected 1 blank line, found 0 Done http://gerrit.cloudera.org:8080/#/c/20192/1/tests/custom_cluster/test_restart_services.py@227 PS1, Line 227: + > flake8: W504 line break after binary operator Done -- To view, visit http://gerrit.cloudera.org:8080/20192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71bec8f67f80b0bdfe0a6cc46a16ef624163d8b Gerrit-Change-Number: 20192 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:05:26 +0000 Gerrit-HasComments: Yes
