Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20192 )
Change subject: IMPALA-12267: DMLs/DDLs can hang as a result of catalogd restart ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc@382 PS1, Line 382: 5 > > When catalog_update_info_ really changes, we exit the loop. Ok, now I understand what you mean. Do you think we should have a limit on the number of iterations (e.g. 10) AND the time or do you think we shouldn't have a timeout at all? Without a timeout, can't we also wait indefinitely in the case of IMPALA-12267 if there are no catalog changes? Or does the statestore also send updates if there are no changes? http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc@2269 PS1, Line 2269: we only got the updates about some but not all restarts : // - the update about the catalogd that has 'catalog_service_id' has not : // arrived yet > Yeah, exactly. In such case (IMPALA-10875), client might see stale metadata So do you think this comment is OK or should I change it? -- To view, visit http://gerrit.cloudera.org:8080/20192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71bec8f67f80b0bdfe0a6cc46a16ef624163d8b Gerrit-Change-Number: 20192 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 19 Jul 2023 15:02:54 +0000 Gerrit-HasComments: Yes
