Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 )
Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20204/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/20204/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@234 PS1, Line 234: indentPrefix + "Iceberg snapshot id: " + String.valueOf(snapshotId_) + "\n"); > I think this should break the Iceberg-related planner tests. Yea I realised when Andrew pointed out the "no tests" problem :) http://gerrit.cloudera.org:8080/#/c/20204/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20204/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@213 PS1, Line 213: getIceTable().snapshotId() > Will it be correct in case of time travel? Done, good catch -- To view, visit http://gerrit.cloudera.org:8080/20204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0b4967429ea733729ad8e44df32e3b24b88525 Gerrit-Change-Number: 20204 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 09:38:17 +0000 Gerrit-HasComments: Yes
