Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20204 )
Change subject: IMPALA-12072: Include snapshot id of Iceberg tables in query plan / profile ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20204/4/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20204/4/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@148 PS4, Line 148: timeTravelSpec.getAsOfVersion(); When there's time travel based on time, timeTravelSpec.getAsOfVersion() returns -1. We need to retrieve the snapshot id from the TableScan object, see IcebergUtil.planFiles(). Can you add some tests for 'FOR SYSTEM_VERSION AS OF'? Please watch out if you need to specify timezones for the tests. -- To view, visit http://gerrit.cloudera.org:8080/20204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0b4967429ea733729ad8e44df32e3b24b88525 Gerrit-Change-Number: 20204 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 13:21:39 +0000 Gerrit-HasComments: Yes
