Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier Partitioned Hash Join with a limit could hang when using mt_dop>0, due to the cyclic barrier in PHJBuilder is not cancelled properly. Added possibility to unregister threads from the synchronization and a call to it to PHJNode::Close(), so closing threads won't block still processing ones. Testing: - Added new unit tests covering new feature - Added e2e test to make sure the join does not hang Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Reviewed-on: http://gerrit.cloudera.org:8080/20179 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h M be/src/exec/partitioned-hash-join-node.cc M be/src/util/cyclic-barrier-test.cc M be/src/util/cyclic-barrier.cc M be/src/util/cyclic-barrier.h M testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test 7 files changed, 145 insertions(+), 6 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 10 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
