Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20179 )
Change subject: IMPALA-12233: Fixed PHJ hanging caused by cyclic barrier ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Found one tiny nit, otherwise the code looks great! http://gerrit.cloudera.org:8080/#/c/20179/8/be/src/util/cyclic-barrier.cc File be/src/util/cyclic-barrier.cc: http://gerrit.cloudera.org:8080/#/c/20179/8/be/src/util/cyclic-barrier.cc@41 PS8, Line 41: std:: nit: no need for this std:: either -- To view, visit http://gerrit.cloudera.org:8080/20179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be75c7ce99c015964c8bbb547539e6619ba4f9b Gerrit-Change-Number: 20179 Gerrit-PatchSet: 8 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 14:22:16 +0000 Gerrit-HasComments: Yes
