Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20265 )
Change subject: IMPALA-12314: Pre-compile LLVM bytecode with Os ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20265/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20265/4//COMMIT_MSG@138 PS4, Line 138: It would be useful to get more evaluation of this option. Adds a new > After reading this paragraph it was not immediately clear to me that we're Ack http://gerrit.cloudera.org:8080/#/c/20265/4//COMMIT_MSG@140 PS4, Line 140: ersions of > Also, do we have guidelines on which optimisation level could perform bette I don't really know yet, that's why I want to be able to try it out with different test suites. In our test suite Os works best, but there's a lot going on so hard to say definitively what "best" will be. -- To view, visit http://gerrit.cloudera.org:8080/20265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dd1a07ce63dbc2c27b00f450e11eceaa7bb0822 Gerrit-Change-Number: 20265 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 27 Jul 2023 15:52:04 +0000 Gerrit-HasComments: Yes
