Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20265 )
Change subject: IMPALA-12314: Pre-compile LLVM bytecode with Os ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20265/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20265/6//COMMIT_MSG@16 PS6, Line 16: With codegen cache disabled we see across-the-board improvement: : +----------+-----------------------+---------+------------+------------+----------------+ : | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | : +----------+-----------------------+---------+------------+------------+----------------+ : | TPCH(42) | parquet / none / none | 3.28 | -2.33% | 2.44 | -3.42% | : +----------+-----------------------+---------+------------+------------+----------------+ Impressive numbers! Do you know whether this comes from codegen time improvement or faster execution of the generated code? I guess it is mainly from codegen time as we get less benefit with codegen cache, but it would be good to know whether there is any significant change in the actual execution. -- To view, visit http://gerrit.cloudera.org:8080/20265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dd1a07ce63dbc2c27b00f450e11eceaa7bb0822 Gerrit-Change-Number: 20265 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 12:56:58 +0000 Gerrit-HasComments: Yes
