Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20272 )
Change subject: IMPALA-12311: Do not add a trailing newline when updating a golden file ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py@298 PS1, Line 298: return '\n'.join(lines) Are you sure this is enough? I try scenario from the JIRA and it still shows extra new lines after running test with --update_results. diff testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test logs/ee_tests/QueryTest_decimal-exprs.test Also, the method method indicate that this is expected to be the inverse of split_section_lines, which have explicit assertion that section_str should ends with '\n'. Instead of just removing the final '\n' here, maybe check if last character is already '\n' or not and skip accordingly? -- To view, visit http://gerrit.cloudera.org:8080/20272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7668a437267bd76afecba8f87ead32d82580414 Gerrit-Change-Number: 20272 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 27 Jul 2023 21:01:05 +0000 Gerrit-HasComments: Yes
