Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20272 )
Change subject: IMPALA-12311: Do not add a trailing newline when updating a golden file ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py@327 PS1, Line 327: if section_value.strip(): Looks like the real culprit is here. strip() should be at the end of line 326, not here. -- To view, visit http://gerrit.cloudera.org:8080/20272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7668a437267bd76afecba8f87ead32d82580414 Gerrit-Change-Number: 20272 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 27 Jul 2023 21:53:42 +0000 Gerrit-HasComments: Yes
