Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20266 )
Change subject: IMPALA-12315: Remove codegen inline hint ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20266/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20266/1//COMMIT_MSG@48 PS1, Line 48: The change actually seems to be more sizable when combined with : IMPALA-12314, where we see Delta(GeoMean) go from -2.45% to -3.49%. > Was codegen cache enabled during the tests? This was with codegen cache disabled. I can do another run with it enabled. -- To view, visit http://gerrit.cloudera.org:8080/20266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99721ed102dc8007f41f5a0e78f95eabbc962b46 Gerrit-Change-Number: 20266 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 17:03:24 +0000 Gerrit-HasComments: Yes
