Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20266 )
Change subject: IMPALA-12315: Remove codegen inline hint ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20266/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20266/1//COMMIT_MSG@48 PS1, Line 48: The change actually seems to be more sizable when combined with : IMPALA-12314, where we see Delta(GeoMean) go from -2.45% to -3.49%. > This was with codegen cache disabled. I can do another run with it enabled. This shows a similarly sized delta in the opposite direction when codegen cache is enabled. So maybe not worth changing. https://jenkins.impala.io/job/perf-AB-test/464: +----------+-----------------------+---------+------------+------------+----------------+ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +----------+-----------------------+---------+------------+------------+----------------+ | TPCH(42) | parquet / none / none | 3.25 | +0.26% | 2.33 | +0.16% | +----------+-----------------------+---------+------------+------------+----------------+ +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+ | Workload | Query | File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval | Tval | +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+ | TPCH(42) | TPCH-Q22 | parquet / none / none | 1.55 | 1.52 | +1.79% | 2.41% | 2.18% | 50 | +2.74% | 4.11 | 3.85 | | TPCH(42) | TPCH-Q4 | parquet / none / none | 1.82 | 1.79 | +1.50% | 2.74% | 2.96% | 50 | +2.30% | 2.73 | 2.62 | | TPCH(42) | TPCH-Q5 | parquet / none / none | 2.24 | 2.21 | +1.35% | 1.88% | 1.99% | 50 | +1.88% | 3.14 | 3.47 | | TPCH(42) | TPCH-Q8 | parquet / none / none | 3.51 | 3.47 | +1.08% | 1.29% | 1.56% | 50 | +1.27% | 3.39 | 3.73 | | TPCH(42) | TPCH-Q9 | parquet / none / none | 8.99 | 8.90 | +1.04% | 1.00% | 1.05% | 50 | +1.10% | 4.53 | 5.05 | | TPCH(42) | TPCH-Q18 | parquet / none / none | 4.99 | 4.95 | +0.83% | 2.31% | 2.19% | 50 | +0.92% | 2.32 | 1.83 | | TPCH(42) | TPCH-Q15 | parquet / none / none | 2.54 | 2.53 | +0.62% | 1.65% | 1.50% | 50 | +0.26% | 1.94 | 1.97 | | TPCH(42) | TPCH-Q20 | parquet / none / none | 1.81 | 1.79 | +0.60% | 1.83% | 1.68% | 50 | +0.16% | 2.08 | 1.70 | | TPCH(42) | TPCH-Q6 | parquet / none / none | 0.79 | 0.79 | +0.63% | 3.40% | 3.32% | 50 | -0.02% | -0.23 | 0.93 | | TPCH(42) | TPCH-Q21 | parquet / none / none | 13.78 | 13.76 | +0.16% | 0.66% | 0.45% | 50 | +0.05% | 1.64 | 1.45 | | TPCH(42) | TPCH-Q19 | parquet / none / none | 1.29 | 1.29 | +0.05% | 2.59% | 1.79% | 50 | +0.03% | 0.53 | 0.12 | | TPCH(42) | TPCH-Q11 | parquet / none / none | 0.57 | 0.57 | +0.05% | 2.99% | 3.71% | 50 | +0.03% | 0.25 | 0.08 | | TPCH(42) | TPCH-Q7 | parquet / none / none | 2.60 | 2.60 | +0.02% | 1.97% | 1.67% | 50 | -0.01% | -0.14 | 0.05 | | TPCH(42) | TPCH-Q3 | parquet / none / none | 6.67 | 6.68 | -0.04% | 0.74% | 0.75% | 50 | -0.01% | -0.30 | -0.30 | | TPCH(42) | TPCH-Q1 | parquet / none / none | 2.75 | 2.75 | -0.04% | 1.78% | 1.36% | 50 | -0.02% | -0.29 | -0.13 | | TPCH(42) | TPCH-Q13 | parquet / none / none | 5.90 | 5.90 | -0.07% | 1.32% | 1.61% | 50 | -0.02% | -0.34 | -0.25 | | TPCH(42) | TPCH-Q2 | parquet / none / none | 0.88 | 0.88 | -0.43% | 3.26% | 2.57% | 50 | -0.05% | -0.29 | -0.73 | | TPCH(42) | TPCH-Q17 | parquet / none / none | 1.82 | 1.83 | -0.53% | 1.55% | 2.06% | 50 | -0.11% | -1.33 | -1.45 | | TPCH(42) | TPCH-Q12 | parquet / none / none | 1.55 | 1.56 | -0.65% | 1.91% | 1.90% | 50 | -0.13% | -1.73 | -1.71 | | TPCH(42) | TPCH-Q16 | parquet / none / none | 0.99 | 1.00 | -0.98% | 2.95% | 3.10% | 50 | -0.30% | -1.89 | -1.63 | | TPCH(42) | TPCH-Q14 | parquet / none / none | 1.69 | 1.71 | -1.13% | 3.15% | 2.42% | 50 | -0.26% | -1.81 | -2.03 | | TPCH(42) | TPCH-Q10 | parquet / none / none | 2.82 | 2.88 | -2.23% | 3.66% | 2.76% | 50 | -1.90% | -4.79 | -3.49 | +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+ -- To view, visit http://gerrit.cloudera.org:8080/20266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99721ed102dc8007f41f5a0e78f95eabbc962b46 Gerrit-Change-Number: 20266 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 23:40:06 +0000 Gerrit-HasComments: Yes
