Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20295 )
Change subject: IMPALA-12327: Iceberg V2 operator wrong results in PARTITIONED mode ...................................................................... Patch Set 5: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/20295/4/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/20295/4/be/src/exec/iceberg-delete-node.cc@332 PS4, Line 332: *probe_pos - current_probe_pos_ > If I understand what 'current_probe_pos_' and '*probe_pos' means I think th Ouch, good catch. http://gerrit.cloudera.org:8080/#/c/20295/4/be/src/exec/iceberg-delete-node.cc@332 PS4, Line 332: const int64_t step = *probe_pos - current_probe_pos_; > This 'step' is only used for checking if we process the next row ID that is I introduced a bool, but for readability, I also kept 'step'. http://gerrit.cloudera.org:8080/#/c/20295/4/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/20295/4/testdata/bin/create-load-data.sh@436 PS4, Line 436: # TODO: Why is there a REMOTE_LOAD condition? See IMPALA-4347 > Just wondering if this step could be added to functional_schema_template.sq Thanks, this made me realize I can fix the original iceberg_lineitem_multiblock table, so I don't need to add a new one. http://gerrit.cloudera.org:8080/#/c/20295/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/20295/4/testdata/datasets/functional/functional_schema_template.sql@3719 PS4, Line 3719: ---- CREATE_HIVE > Is there a way to load the necessary file into this location without runnin Removed this. http://gerrit.cloudera.org:8080/#/c/20295/4/testdata/datasets/functional/functional_schema_template.sql@3722 PS4, Line 3722: t2.test_id c3, min(t1.bigint_col) min_bigint, min(t2.test_zip) min_zip > Nice! The branch new CONVERT TO ICEBERG in action :) Yeah, but I also had to remove this as this table became redundant. :) -- To view, visit http://gerrit.cloudera.org:8080/20295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89a53e812af8c3b8ec5bc27bca0a50dcac5d924 Gerrit-Change-Number: 20295 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 02 Aug 2023 11:25:39 +0000 Gerrit-HasComments: Yes
