Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/20295 )
Change subject: IMPALA-12327: Iceberg V2 operator wrong results in PARTITIONED mode ...................................................................... Patch Set 5: Code-Review+1 (1 comment) LGTM, feel free to carry over http://gerrit.cloudera.org:8080/#/c/20295/5/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/20295/5/be/src/exec/iceberg-delete-node.cc@332 PS5, Line 332: probe_pos Maybe we could rename this guy to next_probe_pos, for better readability. In theory, this could cause an UB (integer overflow. I wonder if UBSAN build would detect it). At that point we have bigger problems to worry about, but not too hard to fix with different ordering: bool is_consecutive_pos = false; if(current_probe_pos_ != INVALID_ROW_ID) { const step = *next_probe_pos - current_probe_pos_; is_consecutive_pos = step == 1; } -- To view, visit http://gerrit.cloudera.org:8080/20295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89a53e812af8c3b8ec5bc27bca0a50dcac5d924 Gerrit-Change-Number: 20295 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 02 Aug 2023 11:45:03 +0000 Gerrit-HasComments: Yes
