Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20294 )
Change subject: IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20294/3/bin/bootstrap_build.sh File bin/bootstrap_build.sh: http://gerrit.cloudera.org:8080/#/c/20294/3/bin/bootstrap_build.sh@64 PS3, Line 64: ./buildall.sh -notests -so > Ah, create-load-data calls copy-udfs-udas, which makes a few specific targe This change was intended to fix the failure in copy-udfs-udas. But it turns out that 'bootstrap_build.sh' is called in 'jenkins/build-only.sh', which is not used to run all tests. It seems that we run tests using 'jenkins/dockerized-impala-run-tests.sh', which calls './buildall.sh -format -testdata -notests' to build Impala and load data. Considering that building all backend tests is not necessary, I fixed the issue in copy-udfs-udas by manually running cmake again before building tests. -- To view, visit http://gerrit.cloudera.org:8080/20294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a Gerrit-Change-Number: 20294 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 04 Aug 2023 04:53:21 +0000 Gerrit-HasComments: Yes
