Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20294 )
Change subject: IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Thanks for fixing this issue! I tried the build and deployed the package on CentOS 7.9. Everything works fine. http://gerrit.cloudera.org:8080/#/c/20294/5/testdata/bin/copy-udfs-udas.sh File testdata/bin/copy-udfs-udas.sh: http://gerrit.cloudera.org:8080/#/c/20294/5/testdata/bin/copy-udfs-udas.sh@58 PS5, Line 58: cmake . ${CMAKE_ARGS[@]} optional: Can we skip this when we are building Impala without the 'notests' flag? Not sure if there is a way to get the current build options. -- To view, visit http://gerrit.cloudera.org:8080/20294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a Gerrit-Change-Number: 20294 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 11:00:47 +0000 Gerrit-HasComments: Yes
