Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning ...................................................................... Patch Set 6: (4 comments) Hi Quanlong and Daniel, I'm back. I have solved some problems, thanks very much for your review. http://gerrit.cloudera.org:8080/#/c/19517/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/3//COMMIT_MSG@7 PS3, Line 7: even > "even" ? Done http://gerrit.cloudera.org:8080/#/c/19517/3//COMMIT_MSG@13 PS3, Line 13: This patch moves the logics to where the query options are ready > Please mention the cause of the bug and how the query options are added. E. Done http://gerrit.cloudera.org:8080/#/c/19517/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/4//COMMIT_MSG@7 PS4, Line 7: even > Nit: even, not event. Done http://gerrit.cloudera.org:8080/#/c/19517/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/19517/3/be/src/service/impala-server.cc@1247 PS3, Line 1247: > Plase add a comment, e.g. "Add profile info items that are ready after RunF Done -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 04 Aug 2023 06:48:27 +0000 Gerrit-HasComments: Yes
