Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning ...................................................................... Patch Set 6: (1 comment) The failed tests are all about "Query Options (set by configuration and planner)" not exist in the retried profile. http://gerrit.cloudera.org:8080/#/c/19517/6/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/19517/6/be/src/runtime/query-driver.cc@285 PS6, Line 285: UpdateInfoString I think we should use 'AddInfoString' since this field doesn't exist yet. 'UpdateInfoString' will skip the update if the key doesn't exist: https://github.com/apache/impala/blob/e155ab35f5823f766bb8d8e3a2b9d13e0622fee3/be/src/util/runtime-profile.cc#L1131 In contrast, "Query Type" should use UpdateInfoString() since it's already added in the constructor of ClientRequestState: https://github.com/apache/impala/blob/e155ab35f5823f766bb8d8e3a2b9d13e0622fee3/be/src/service/client-request-state.cc#L156 -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 21 Aug 2023 03:28:11 +0000 Gerrit-HasComments: Yes
