Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/20172 )
Change subject: PROTOTYPE: Rearrange shell directory structure to match the
pypi package
......................................................................
Patch Set 3:
> Thanks to work on this. Previously, I manually updated the version
> in ${IMPALA_HOME}/bin/version.info and set "RELEASE_TYPE" and
> "OFFICIAL" environment variables when running
> packaging/make_python_package.sh
> to generate the pypi package for pre-release, like 4.3.0a4. How do
> we set version and build pypi package for pre-release after this
> patch is merged?
Good point, that's important to support. I think I will change this to keep a
(much smaller) make_python_package.sh script to support that use case.
--
To view, visit http://gerrit.cloudera.org:8080/20172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b54fa90f48c6fe20c66a01403e146a941fc5d4f
Gerrit-Change-Number: 20172
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 08 Aug 2023 19:21:17 +0000
Gerrit-HasComments: No
