Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20172
to look at the new patch set (#4).
Change subject: PROTOTYPE: Rearrange shell directory structure to match the
pypi package
......................................................................
PROTOTYPE: Rearrange shell directory structure to match the pypi package
Impala shell's directory structure does not match what the
pypi package needs, so the make_python_package.sh needs to create
a staging directory to create the appropriate structure.
This rearranges the directory structure so that it is exactly what
we need for the pypi package. Some files are still generated by CMake
(e.g. the impala version python file and the thrift generated python).
The code in make_python_package.sh producing the staging directory is
no longer necessary, and it can simply invoke the setup.py sdict
command.
This moves the shell tarball packaging code to the packaging directory
where the pypi code used to live.
As part of this, the Thrift-generated python code no longer lives in
gen-py. It is placed directly in the shell directory. This fixes up
the paths so that other Python code is referring to the shell code
as it would be if it were pip installed.
Change-Id: I1b54fa90f48c6fe20c66a01403e146a941fc5d4f
---
M README-build.md
M bin/impala-shell.sh
M bin/rat_exclude_files.txt
M bin/set-pythonpath.sh
M common/thrift/CMakeLists.txt
M shell/.gitignore
M shell/CMakeLists.txt
R shell/MANIFEST.in
R shell/README.md
R shell/packaging/impala-shell
M shell/packaging/make_python_package.sh
R shell/packaging/make_shell_tarball.sh
R shell/requirements.txt
R shell/setup.py
M tests/custom_cluster/test_hs2_fault_injection.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/custom_cluster/test_thrift_socket.py
M tests/shell/test_cookie_util.py
M tests/shell/test_shell_client.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
22 files changed, 29 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/20172/4
--
To view, visit http://gerrit.cloudera.org:8080/20172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b54fa90f48c6fe20c66a01403e146a941fc5d4f
Gerrit-Change-Number: 20172
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
