Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19773
to look at the new patch set (#2).
Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context
......................................................................
IMPALA-12076: Use ZSTD interfaces with reusable context
For repeated compression/decompression, ZSTD recommends
constructing a context once via ZSTD_createCCtx()/ZSTD_createDCtx()
and using the set of interfaces that passes in the context explicitly
to avoid constructing the context on each call.
This follows the recommendation and allocates the ZSTD context once for
each compressor / decompressor and reuses it for the lifetime of the
compressor / decompressor.
This gets a minor speedup for small-scale ZSTD TPC-H:
+----------+------------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+------------------------+---------+------------+------------+----------------+
| TPCH(42) | parquet / zstd / block | 3.55 | -1.40% | 2.52 |
-1.63% |
+----------+------------------------+---------+------------+------------+----------------+
Testing:
- Ran core job
- Ran a perf-AB-test job
Change-Id: I5010a56bf8202ccb3f1710425002f81587fd412b
---
M be/src/util/compress.cc
M be/src/util/compress.h
M be/src/util/decompress.cc
3 files changed, 26 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/19773/2
--
To view, visit http://gerrit.cloudera.org:8080/19773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5010a56bf8202ccb3f1710425002f81587fd412b
Gerrit-Change-Number: 19773
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
