Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19773 )
Change subject: IMPALA-12076: Use ZSTD interfaces with reusable context ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19773/2/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/19773/2/be/src/util/compress.h@153 PS2, Line 153: ZSTD_CCtx* stream_ = nullptr; Pretty sure instances of these classes aren't shared across threads. Gzip has a similar construct. Main uses are tmp-file-mgr and hdfs-parquet-table-writer, which create an instance for their particular use (writing a temporary file block or sequentially to a file). -- To view, visit http://gerrit.cloudera.org:8080/19773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5010a56bf8202ccb3f1710425002f81587fd412b Gerrit-Change-Number: 19773 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 16:18:45 +0000 Gerrit-HasComments: Yes
