Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20311 )
Change subject: IMPALA-12334: Add debug symbols to LLVM assert build ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20311/4/source/llvm/build-source-tarball.sh File source/llvm/build-source-tarball.sh: http://gerrit.cloudera.org:8080/#/c/20311/4/source/llvm/build-source-tarball.sh@184 PS4, Line 184: function strip_if_possible() { : filename=$1 : if [[ "$(file -bi $filename)" = application/x-@(executable|sharedlib|archive)* ]] : then : strip -gx "$filename" : fi : } : > Nit: This works, but it's a bit hard for me to follow. Could we do somethin Done -- To view, visit http://gerrit.cloudera.org:8080/20311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c58bfe2233dcec39fcad92fc52ce372165229d8 Gerrit-Change-Number: 20311 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 16:50:13 +0000 Gerrit-HasComments: Yes
